[ML] Ensure EIS auth response exists before executing tests #128640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>non-issue
:ml
jonathan-buttner
added
the
auto-backport
|
Pinging @elastic/ml-core (Team:ML) |
prwhelan
approved these changes
May 30, 2025
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 30, 2025
mridula-s109
pushed a commit
that referenced
this pull request
Jun 2, 2025
* Add response before each test file for eis * Fixing the expected values * Adding response before cluster starts
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 3, 2025
…128640) * Add response before each test file for eis * Fixing the expected values * Adding response before cluster starts
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
…128640) * Add response before each test file for eis * Fixing the expected values * Adding response before cluster starts
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
…128640) * Add response before each test file for eis * Fixing the expected values * Adding response before cluster starts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue I noticed locally where running
./gradlew :x-pack:plugin:inference:qa:inference-service-tests:javaRestTestwould result in a test failure that I could reproduce unless running the entire suite over again. I believe the issue is that since we're using a static variable for the mock web server, the authorization response was only being added once. There are two classes that extendBaseMockEISAuthServerTestwhich I think means that one class would have the response ready but the other class wouldn't. In my local testing the class that would fail would change randomly which seems to indicate that whichever test class got run first would succeed. When a class runs it pops off the response. The way the base class was written it was assuming the class loader would run twice. The strange thing is that the http server would get started on different ports 🤷♂️I'm not sure why this isn't failing in CI though 🤔